orange3-recommendation icon indicating copy to clipboard operation
orange3-recommendation copied to clipboard

Published 20 hours ago • verified publisher icon biolab

Update learners to work with new Orange3 versions

Open robertcv opened this issue 5 years ago • 3 comments

Issue

Fixes #8, #9

Description of changes

Add ConcurrentMixin which moves computation on thread and fix old input/output style.

Includes
  • [X] Code changes
  • [ ] Tests
  • [ ] Documentation

robertcv avatar Sep 20 '19 14:09 robertcv

Have you considered Orange.widgets.utils.concurrent.ConcurrentMixin as an alternative to OWHeavyLearner (or maybe its base)?

lanzagar avatar Sep 23 '19 07:09 lanzagar

@lanzagar Changed code to use ConcurrentMixin. Take a look.

robertcv avatar Sep 23 '19 13:09 robertcv

@VesnaT I combined the functionality into a new base class. This could be then a starting point for how to integrate it into OWBaseLearner but this is beyond this PR (and is probably not trivial because of the different callbacks). The same goes for the resuming of learning.

robertcv avatar Oct 03 '19 09:10 robertcv