orange3-imageanalytics icon indicating copy to clipboard operation
orange3-imageanalytics copied to clipboard

Embedders widget - field for a custom server URL

Open PrimozGodec opened this issue 6 years ago • 5 comments

Issue

No possibility to set custom server url.

Description of changes

Adding a field and functionality for a custom URL set.

Includes
  • [X] Code changes
  • [x] Tests
  • [ ] Documentation

PrimozGodec avatar Sep 18 '18 09:09 PrimozGodec

Codecov Report

Merging #114 into master will decrease coverage by 3.72%. The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #114      +/-   ##
==========================================
- Coverage    79.9%   76.18%   -3.73%     
==========================================
  Files           7        5       -2     
  Lines         622      529      -93     
  Branches       95       84      -11     
==========================================
- Hits          497      403      -94     
- Misses         97       98       +1     
  Partials       28       28

codecov-io avatar Sep 18 '18 10:09 codecov-io

we also need "allow insecure" option, eg. like in curl -k or --insecure (Allow connections to SSL sites without checking certs (H)). We need this if there are self signed certificates installed on the imageanalytics server.

matjazp avatar Sep 21 '18 13:09 matjazp

@lanzagar fixed @matjazp will try to implement. @acopar is it possible to set up a server with the self-generated certificate to test Matjaz's suggestion.

PrimozGodec avatar Sep 21 '18 14:09 PrimozGodec

@matjazp it seems that hyper library does not support "allow insecure" option https://hyper.readthedocs.io/en/latest/advanced.html#ssl-tls-certificate-verification. With @acopar we discussed to just use HTTP instead of HTTPS those cases

PrimozGodec avatar Oct 05 '18 12:10 PrimozGodec

Very useful!!

Corlobin avatar Feb 25 '19 18:02 Corlobin