songbird icon indicating copy to clipboard operation
songbird copied to clipboard

Trim dependencies (and make consistent)

Open mortonjt opened this issue 5 years ago • 1 comments

We definitely don't need

  • sklearn
  • seaborn
  • ipython

Need to trim before version 1.0

Also python3.7 is breaking for some reason ...

mortonjt avatar Mar 12 '19 20:03 mortonjt

Looks like seaborn and ipython aren't used anywhere in the current codebase, although sklearn is (we're importing check_random_state from it). Weirdly enough the setup.py and conda_requirements files don't mention needing sklearn... I guess everyone has just been installing into environments where sklearn is already present :)

This relates to something I've been thinking of for a bit -- we should ideally try to make all of the dependency info consistent. There are (at least) three locations where this info is specified for Songbird:

  1. setup.py
  2. ci/conda_requirements.txt
  3. conda-forge meta.yaml recipe

And all of these are slightly different in some ways -- e.g. setup.py has a different min numpy version than conda_requirements, and the conda-forge recipe explicitly mentions needing sklearn while the other two don't.

Ideally we should be able to make this info consistent somehow (would it be possible to just delegate everything to the setup.py file?), or at least periodically check in to make sure stuff's in sync.

fedarko avatar Feb 04 '20 10:02 fedarko