Daniel Chao

Results 256 comments of Daniel Chao

Re-opened!

Functions are internal to Pkl; not exportable. I don't have any experience working with nix. But: you can write an _in-language_ renderer to turn Pkl into nix. For example, here...

This is definitely something that needs to be improved. Right now, we don't preserve enough information in runtime object to present errors like this, and we'd need to balance this...

> For example, Pkl is (quite) lazy. To do a properly deep type cast, requires forcing everything. This is also why toTyped is shallow. Thinking about properties existing that are...

Thanks! I haven't reviewed this yet, but this is erroring in our CI build, for test `org.pkl.executor.EmbeddedExecutorTest`: ``` org.pkl.executor.ExecutorException: –– Pkl Error –– Exception when making request `GET https://localhost:12110/[email protected]`: PKIX...

Re: CI: yeah, I realize it's kind of painful. We'll need to think through how to make this experience better for ya'll.

@translatenix: ack; I'll get back to you by end of day tomorrow. Thanks again for your work here, and bear with us as we work through all the PRs (including...

> I've addressed everything I could in my latest commit (as per my comments). Once you're ready to merge, please squash before merging (or ask me to squash). We will...

@translatenix: are you planning on addressing the nits here? If so, I'll wait for them before merging. Otherwise, we can go ahead and merge, and we will submit a follow-up...

Cleanup PR here: https://github.com/apple/pkl/pull/295