Philipp C. Heckel

Results 281 comments of Philipp C. Heckel

I would have thought that Go does that under the hood :shrug:

I'm running it on ntfy.sh as /tmp/ntfy.sock; and it works fine, and has the correct permissions. This is good enough IMHO. ``` root@ntfy:~# ll /tmp/ntfy.sock srw-rw---- 1 ntfy ntfy 0...

I do believe this is fixed by #677/#509 -- If it still happens, please comment here and I'll re-open.

@rogeliodh @nicois @genofire @benisai @mhameed, and anyone else who is interested, what metrics would you like to see? Here's my current WIP: ``` messagesPublishedSuccess: prometheus.NewCounter(prometheus.CounterOpts{ Name: "ntfy_messages_published_success", }), messagesPublishedFailure: prometheus.NewCounter(prometheus.CounterOpts{...

I think I am content the way I have implemented this. I may add a few more metrics and then call it a day for now. We can always add...

The funniest thing: Apparently some other dependency had pulled in the prometheus client already, so this won't add any dependencies, whooo. ![image](https://user-images.githubusercontent.com/664597/225029948-6ad8a1ba-15d1-40dc-ad04-7d334f5992b9.png)

:loudspeaker: Question around the `/metrics` endpoint for Prometheus: Right now I have it so that if you configure `listen-metrics-http`, it'll listen on a different IP/port for the metrics. But I...

Thanks. I'll check them out tonight. It feels weird to me that these tools allow them to be publicly available. Metrics are sensitive information and can give attackers insight.

@xenrox Thanks again for the examples. They were great. I did this, and I think I like it: ``` yaml # ntfy can expose Prometheus-style metrics via a /metrics endpoint,...

This is done and will be in the next release.