pash icon indicating copy to clipboard operation
pash copied to clipboard

Docker Push Action Failure

Open angelhof opened this issue 2 years ago • 4 comments

I am not sure how to address this: https://github.com/binpash/pash/actions/runs/2229959382

The automated workflow that pushes images to docker.io didn't seem to work.

angelhof avatar Apr 26 '22 23:04 angelhof

The issue should be fixed now :) I had probably misstyped the dockerhub account username on the repo settings.

Apart from the docker.io images, there are also the github docker images that are identical to the docker.io, just being hosted on a different registry (they can be found below the releases tab on the main repo).

Moreover, should we remove this outdated image on github registry? It hasn't being updated since last year.

Next time there is an bug with CI or something similar, do not hesitate to tag me on the issue/PR!

dkarnikis avatar Apr 28 '22 08:04 dkarnikis

Thanks a lot @dkarnikis! I will tag you if I can't find the solution on my own but do it on your own time. There is no rush :)

Regarding the outdated image, I would prefer having a single default image that is called pash (and is the one visible on top that the people should use by default). No need to actually even publish the fedora and debian images on ghcr. Would that create any issue? Does anyone depend on those packages? If not, I will make a PR to fix it.

angelhof avatar Apr 28 '22 15:04 angelhof

PR #546 modifies the workflow to push a single image on github (and updates the version). If that looks OK, I will merge it and then delete the distro-named images from Github packages.

angelhof avatar Apr 28 '22 15:04 angelhof

@nvasilakis I am thinking of deleting all images on github packages (debian, ubuntu, fedora) and just keep one that is named pash and runs on Ubuntu. The docker images are still on docker.io, and they can be easily built manually, but IMO there is no need to crowd the front page of the repo with several different images, having a single one that everyone should use feels better.

angelhof avatar Apr 28 '22 16:04 angelhof