community icon indicating copy to clipboard operation
community copied to clipboard

Patch/Replace imgui-sfml CMakeLists.txt

Open TheFloatingBrain opened this issue 2 years ago • 1 comments

The imgui-sfml CMakeLists.txt file is rather "wonky", I understand that it is nice to have choices, such as using system dependencies (can conan do this automatically) however despite having all of its dependencies available through conan it cant build without downloading the imgui repository even if all such dependencies are installed and specified in requirements due to its cmake file.

Trying to modify its conanfile.py myself (I thought it was not building) getting these options right to make it build in a /build directory is tricky (true once it is successfully installed, there is no need, but this is meant to demonstrate the the issue with the CMakeLists.txt file)

Should its CMakeLists.txt be patched/replaced?

TheFloatingBrain avatar Jun 09 '22 03:06 TheFloatingBrain

The fact that the receipe can't be build without imgui is a problem but doesn't it comes from the conanfile.py file ? Actually I don't see the problem with the CMakeLists.txt file (or can you explain what the problem is ?)

Gryfenfer97 avatar Sep 07 '22 20:09 Gryfenfer97