community
community copied to clipboard
bincrafters
wxWidgets fails when cross-compiling;
Description
Fix library file names to match package recipe when cross compiling.
Related Issue
closes #1432
Motivation and Context
Corrects library names when cross compiling. This is easy to reproduce on macOS (and probably iOS). The current wxWidgets code in git has changed further, and I've included a 3.1.6 patch even though it hasn't been released. The original patch is definitely 3.1.5 only (3.1.4 and early don't name the libraries this way.)
How Has This Been Tested?
See steps in #1432 The test recipe is able to link now. This change affects cross compiling Linux too, although I don't think that's possible to test until a Conan GTK recipe exists? Windows (even if cross compiled) has different library names.
~~If 3.1.6 isn't yet released, can't the patch be still be included in the release?~~ Nvm, I just read your issue. It is still unusual to add patches for versions we don't have yet. I would rather vote for not adding it for now
We have a GTK Conan package for 3.x and 4.x https://conan.io/center/gtk
Is wxWidgets compatible with it?
Yeah, I guess that was confusing. I've removed the 3.1.6 patch and I'll check back after it's released.
As for GTK, I didn't look into cross compiling Linux after finding issue #861 which I believe is where moving wxWidget to the Conan GTK package should be addressed? It seem to be still be open (some of the Linux builds here are failing). That issue seem to be out of date because the GTK package didn't seem to exist at the time. I can try to take a look separately. Can we ignore that here or would you like that to be fixed first to fully test cross compiling?
It looks like the wxWidgets recipe won't cross-compile on Linux anytime soon. There are other system dependencies besides GTK. This PR is effectively for macOS only.