community icon indicating copy to clipboard operation
community copied to clipboard

Published 20 hours ago • verified publisher icon bincrafters

sdl2: remove now obsolete workaround

Open Croydon opened this issue 4 years ago • 4 comments

Croydon avatar Nov 16 '21 23:11 Croydon

jack can't be found anymore 👀

e.g.

https://github.com/bincrafters/community/runs/4231750091?check_suite_focus=true#step:5:2070

Croydon avatar Nov 17 '21 00:11 Croydon

Shouldn't we remove sdl2 ? https://github.com/bincrafters/community/pull/1414

ericLemanissier avatar Nov 23 '21 14:11 ericLemanissier

I would like to keep it around for a while longer as it isn't a full replacement yet (i.e. Jack support is missing on Linux in the CCI version)

Croydon avatar Dec 01 '21 16:12 Croydon

Ok, so jack cannot be found because the recipe is using the conan version of pkgconf, which does not look in the packages provided by the system. A workaround is to set environment variable PKG_CONFIG_PATH=/usr/lib/x86_64-linux-gnu/pkgconfig/, but it is obviously not portable across distros. Otherwise we should remove the use of conan's pkgconf, and use the system's pkg-config instead. (I have no idea why it passed before)

ericLemanissier avatar Dec 02 '21 10:12 ericLemanissier