bincode icon indicating copy to clipboard operation
bincode copied to clipboard

impl Enode for IpAddr and the other like it ( unstable feature `ip_in_core` )

Open elpiel opened this issue 1 year ago • 5 comments

It's still awaiting stabilisation but it would be nice to include this in 2.0 release and track it's progress as an unstable feature.

Tracking issue: https://github.com/rust-lang/rust/issues/108443

elpiel avatar Jun 10 '23 07:06 elpiel

I'm not keen on having a dedicated feature for this. It shouldn't be a breaking change to modify this in a minor version, so once this is stabilized I think we can just patch it in

VictorKoenders avatar Jun 13 '23 07:06 VictorKoenders

Ok, that's fair. My main pain point right now is on no_std. Right now I must create and maintain a separate struct for encoding/decoding IP addresses instead of using bincode's impl. For no_std with e.g. embassy we're already using nightly so enabling unstable features like this one makes sense.

elpiel avatar Jun 15 '23 06:06 elpiel

As far as I can tell this should be stable in 1.76 next week

VictorKoenders avatar Feb 01 '24 14:02 VictorKoenders

Looks like I was wrong and this will be stable in rust 1.77, which should be released on march 21th

VictorKoenders avatar Feb 08 '24 11:02 VictorKoenders

ip_in_core is stabilised! :tada:

elpiel avatar Apr 05 '24 09:04 elpiel