binci icon indicating copy to clipboard operation
binci copied to clipboard

Providing build arguments via `--build-arg` option when using `dockerfile` directive

Open pavelexpertov opened this issue 5 years ago • 2 comments

Hello, when you provide a dockerfile directive, it builds an image automatically.

However, I am struggling to find information whether it's possible to provide build arguments when it builds because it's a necessary value for building an image.

So, any ways to provide such arguments via the yaml file?

pavelexpertov avatar Oct 29 '19 13:10 pavelexpertov

@Fluidbyte

I have looked at the source code and I see you don't have the feature.

I believe it is a non-trivial thing to add the ability for people to provide build arguments to a local Dockerfile by providing build arguments when you call commands (e.g. binci shell --build-arg variable_name=value).

I am considering to make a pull-request for to implement such a feature. Hopefully you will be able to guide me as well as review the change to meet common needs and goals.

pavelexpertov avatar Oct 31 '19 16:10 pavelexpertov

@pavelexpertov I'm happy to review and help with any PR you submit. I'm tied up for the next several weeks but I'll watch for anything you push.

ksafranski avatar Oct 31 '19 17:10 ksafranski