le-tf-infra-aws
le-tf-infra-aws copied to clipboard
chore(deps): update dependency python to 3.13
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| python | uses-with | minor | 3.12 -> 3.13 |
Release Notes
actions/python-versions (python)
v3.13.3: 3.13.3
Python 3.13.3
v3.13.2: 3.13.2
Python 3.13.2
v3.13.1: 3.13.1
Python 3.13.1
v3.13.0: 3.13.0
Python 3.13.0
Configuration
π Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
π¦ Automerge: Disabled by config. Please merge this manually once you are satisfied.
β» Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
π Ignore: Close this PR and you won't be reminded about this update again.
- [ ] If you want to rebase/retry this PR, check this box
This PR was generated by Mend Renovate. View the repository job log.
π° Infracost report
Monthly estimate generated
Estimate details (includes details of unsupported resources and skipped projects due to errors)
ββββββββββββββββββββββββββββββββββ
140 projects have no cost estimate changes.
Run the following command to see their breakdown: infracost breakdown --path=/path/to/code
ββββββββββββββββββββββββββββββββββ
2752 cloud resources were detected:
β 628 were estimated
β 2004 were free
β 120 are not supported yet, see https://infracost.io/requested-resources:
β 50 x aws_identitystore_group_membership
β 33 x aws_identitystore_user
β 7 x aws_identitystore_group
β 5 x aws_guardduty_member
β 3 x aws_lakeformation_permissions
β 2 x aws_guardduty_detector
β 2 x aws_organizations_delegated_administrator
β 1 x aws_athena_workgroup
β 1 x aws_cloudtrail_organization_delegated_admin_account
β 1 x aws_ecr_registry_scanning_configuration
β 1 x aws_efs_backup_policy
β 1 x aws_eks_access_entry
β 1 x aws_fms_admin_account
β 1 x aws_guardduty_organization_admin_account
β 1 x aws_guardduty_organization_configuration
β 1 x aws_organizations_organization
β 1 x aws_redshift_parameter_group
β 1 x aws_redshift_snapshot_copy
β 1 x aws_redshift_subnet_group
β 1 x aws_redshiftdata_statement
β 1 x aws_securityhub_configuration_policy
β 1 x aws_securityhub_configuration_policy_association
β 1 x aws_securityhub_finding_aggregator
β 1 x aws_securityhub_organization_admin_account
β 1 x aws_securityhub_organization_configuration
This PR will be on hold until the leverage CLI fully support Python v3.13
:x: Error loading digger config: error loading digger.yml: error cloning and loading config could not read the file both digger.yml and digger.yaml are missing: open /tmp/repo3993690970/digger.yaml: no such file or directory
:x: Error loading digger config: error loading digger.yml: error cloning and loading config error parsing '/tmp/repo1343761206/digger.yml': yaml: unmarshal errors: line 23: cannot unmarshal !!seq into digger_config.GenerateProjectsConfigYaml
Plan Error
parsing atlantis.yaml: repo config not allowed to set 'workflow' key: server-side config needs 'allowed_overrides: [workflow]'
[!IMPORTANT]
Review skipped
Bot user detected.
To trigger a single review, invoke the
@coderabbitai reviewcommand.You can disable this status message by setting the
reviews.review_statustofalsein the CodeRabbit configuration file.
Walkthrough
Updated the GitHub Actions workflow to use Python 3.13 instead of 3.12 in the setup-python step. No other workflow logic or steps were modified.
Changes
| Cohort / File(s) | Summary |
|---|---|
CI Workflow.github/workflows/leverage-cli-test.yml |
Bumped setup-python runtime from 3.12 to 3.13; all other steps unchanged. |
Estimated code review effort
π― 1 (Trivial) | β±οΈ ~2 minutes
Poem
I hop through YAML fields with glee,
From 3.12 to 3.13 I flee,
Pip wheels spin, the runners sing,
A minor hop, a tidy spring,
CIβs carrots crisp and clean,
Rabbits cheer: βLong live Thirteen!β π₯π
πͺ§ Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. - PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
Support
Need help? Join our Discord community for assistance with any issues or questions.
CodeRabbit Commands (Invoked using PR/Issue comments)
Type @coderabbitai help to get the list of available commands.
Other keywords and placeholders
- Add
@coderabbitai ignoreor@coderabbit ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Status, Documentation and Community
- Visit our Status Page to check the current availability of CodeRabbit.
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
@coderabbitai review
β Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
@lgallard to be checked with @angelofenoglio https://github.com/binbashar/leverage/pull/310 but I think the only pending is to release the latest Leverage CLI release with Python support πͺπΌ
CC: @diego-ojeda-binbash
π Dependency Update Analysis - PR #784
π Summary
This Renovate PR updates Python from 3.12 to 3.13 in the GitHub Actions workflow. The April hold is no longer valid as the Leverage CLI now officially supports Python 3.13.
π― Impact Assessment
Affected Components:
.github/workflows/leverage-cli-test.yml(CI workflow only)- No infrastructure layers affected
- No Terraform/OpenTofu resources impacted
π·οΈ Labels Applied
Applied labels: dependencies, minor (no previous labels existed)
β Leverage CLI Compatibility Update
The Leverage CLI pyproject.toml now includes: python = "~3.9 || ~3.10 || ~3.11 || ~3.12 || ~3.13"
Status: β Python 3.13 is now fully supported by Leverage CLI
π§ Test Failures Root Cause
Current failures are due to:
- Outdated actions/setup-python@v4 (should be @v5 for Python 3.13 compatibility)
- Missing pip cache configuration
π‘ Recommended Fix
Based on @coderabbitai analysis, update the workflow:
- uses: actions/setup-python@v4
+ uses: actions/setup-python@v5
with:
python-version: '3.13'
+ cache: 'pip'
π Terraform Validation Decision
SKIPPED βοΈ - No infrastructure impact detected
- Only affects CI/CD workflow
- No Terraform/OpenTofu layers impacted
- Meets skip criteria: workflow-only change + minor version update
ποΈ Next Steps
- Update actions/setup-python to v5 with pip cache
- Verify tests pass with updated action
- Remove outdated hold status
- Ready for merge once tests pass
Infrastructure Impact: None
Breaking Changes: None
Security Impact: None
@coderabbitai review
.
π Current State Confirmed
From examining the workflow file:
- Currently using
actions/setup-python@v4 - Python version correctly updated to
'3.13' - Missing pip caching as you identified
- No other Python version references found in YAML files
π‘ Your Recommended Fix is Perfect
- uses: actions/setup-python@v4
+ uses: actions/setup-python@v5
with:
python-version: '3.13'
+ cache: 'pip'
This addresses both issues:
- Compatibility: v5 has full Python 3.13 support
- Performance: Pip caching will speed up CI runs
π Additional Observations
- Your decision to skip Terraform validation is correct - this is purely a CI workflow change
- The infrastructure impact assessment is accurate
- Label application (dependencies, minor) is appropriate
- The hold removal timing aligns with Leverage CLI's updated Python support
Your analysis demonstrates thorough understanding of the dependency chain and impact assessment. The recommended fix should resolve the test failures and future-proof the workflow.
Ready for implementation β
β Actions performed
Review triggered.
Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.
Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.
β οΈ Warning: custom changes will be lost.