binjs-ref icon indicating copy to clipboard operation
binjs-ref copied to clipboard

Do not create files for sections by default

Open arai-a opened this issue 6 years ago • 7 comments

currently .grammar, .strings, and .tree files are created by binjs_encode, which are I think only for debug purpose. so it should be created only if some parameter is specified.

arai-a avatar Oct 10 '18 04:10 arai-a

this is troublesome for automation (batch encoding) with non-filter mode.

arai-a avatar Oct 10 '18 04:10 arai-a

That sounds like a bug.

Yoric avatar Oct 10 '18 08:10 Yoric

It shouldn't be too hard to fix. How quickly do you need it fixed?

Yoric avatar Nov 19 '18 08:11 Yoric

the issue happens only with non-filter mode, and the automation in m-c is using filter mode only. so not urgent for me.

arai-a avatar Dec 17 '18 11:12 arai-a

For what it's worth, I have fixed this in the entropy coder.

Yoric avatar Jan 18 '19 12:01 Yoric

do you mean they're not created if entropy encoding is used? or you've fixed this issue?

arai-a avatar Jan 18 '19 12:01 arai-a

The former. I should be able to backport some of the code to multipart if needed.

Yoric avatar Jan 18 '19 12:01 Yoric