authlogic
authlogic copied to clipboard
Support Rails 7.2
Fixes #771.
For those who need to use this fix before the PR is merged, you can add the gem to your Gemfile like this:
gem "authlogic", github: "binarylogic/authlogic", ref: "refs/pull/770/head"
Just in case GH notification miss - @tiegz FYI
Is there a timeline for merge?
Tracking the PR ref is working for me but would love to see this get merged.
Looks good. Is there a plan for when merging is expected?
@zhuravel Rails 8.0 is just around the corner. Are you able to loosen rails version restriction or maybe create separate PR for it?
@morgoth Done.
FYI: Code from this PR works fine for us on Rails 8.0.0.rc1 in production.
@binarylogic @jaredbeck @tiegz Can any of you review this and make a release?
@msuliq I wanted to kindly follow up on this PR to see if there's anything we can move it forward since the other maintainers may be busy with life events.
@kimyu92 thanks for the follow up, I’d be happy to assist in any way I can to help move this PR forward since I have been using this gem with reference to this branch, but I’m not currently a maintainer of this gem and don't have permissions to approve and merge PR's, I’d be more than willing to take on that responsibility if the maintaining team sees value in it. Let me know how I can help
@kimyu92 @msuliq sorry, I'm not longer a maintainer on this repo/gem. Currently I think the lineup is @binarylogic and @jaredbeck
Hi everyone, this looks good to me. I will merge when the tests pass.
@binarylogic The tests have passed. Ready for a release
@binarylogic Do we have any ETA?
Anyone here who can push the button? ⏯️
@binarylogic Do we want to follow up with a version release?
A tag with v6.4.4 would be perfect :-)
Just arrived here after noticing the version downgrade when updating to Rails 7.2. @binarylogic, is there anything further stopping a new gem release with the Rails 7.2 and 8 support? Right now bundle downgrades the gem to version to 3.4.2 which must have been the last version with a looser (or no) rails decency requirement.
@binarylogic Similar to the last comments, I'd like to know if anything is preventing the release of a new gem version and if we can help in any way since it was merged almost two months ago, and the current documentation wrongly implies support for Ruby 7.x and 8.x:
Just an FYI for anybody that missed it, this was released in Version 6.5.0. Thank you to all for getting this merged in and released. 🙏
No worries! :) It loads much nicer now too which is good :)