authlogic icon indicating copy to clipboard operation
authlogic copied to clipboard

Support Rails 7.2

Open zhuravel opened this issue 1 year ago • 4 comments

Fixes #771.

For those who need to use this fix before the PR is merged, you can add the gem to your Gemfile like this:

gem "authlogic", github: "binarylogic/authlogic", ref: "refs/pull/770/head"

zhuravel avatar Aug 10 '24 12:08 zhuravel

Just in case GH notification miss - @tiegz FYI

morgoth avatar Aug 16 '24 08:08 morgoth

Is there a timeline for merge?

kjanoudi avatar Aug 31 '24 18:08 kjanoudi

Tracking the PR ref is working for me but would love to see this get merged.

sstrudeau avatar Sep 09 '24 13:09 sstrudeau

Looks good. Is there a plan for when merging is expected?

mjansing avatar Oct 14 '24 19:10 mjansing

@zhuravel Rails 8.0 is just around the corner. Are you able to loosen rails version restriction or maybe create separate PR for it?

morgoth avatar Oct 22 '24 05:10 morgoth

@morgoth Done.

zhuravel avatar Oct 22 '24 12:10 zhuravel

FYI: Code from this PR works fine for us on Rails 8.0.0.rc1 in production.

morgoth avatar Oct 28 '24 07:10 morgoth

@binarylogic @jaredbeck @tiegz Can any of you review this and make a release?

kimyu-ng avatar Nov 06 '24 21:11 kimyu-ng

@msuliq I wanted to kindly follow up on this PR to see if there's anything we can move it forward since the other maintainers may be busy with life events.

kimyu-ng avatar Nov 15 '24 15:11 kimyu-ng

@kimyu92 thanks for the follow up, I’d be happy to assist in any way I can to help move this PR forward since I have been using this gem with reference to this branch, but I’m not currently a maintainer of this gem and don't have permissions to approve and merge PR's, I’d be more than willing to take on that responsibility if the maintaining team sees value in it. Let me know how I can help

msuliq avatar Nov 15 '24 16:11 msuliq

@kimyu92 @msuliq sorry, I'm not longer a maintainer on this repo/gem. Currently I think the lineup is @binarylogic and @jaredbeck

tiegz avatar Nov 15 '24 17:11 tiegz

Hi everyone, this looks good to me. I will merge when the tests pass.

binarylogic avatar Nov 15 '24 17:11 binarylogic

@binarylogic The tests have passed. Ready for a release

morgoth avatar Nov 18 '24 12:11 morgoth

@binarylogic Do we have any ETA?

kimyu-ng avatar Dec 03 '24 15:12 kimyu-ng

Anyone here who can push the button? ⏯️

RalphAtHamburg avatar Dec 13 '24 17:12 RalphAtHamburg

@binarylogic Do we want to follow up with a version release?

kimyu-ng avatar Jan 08 '25 14:01 kimyu-ng

A tag with v6.4.4 would be perfect :-)

RalphAtHamburg avatar Jan 09 '25 09:01 RalphAtHamburg

Just arrived here after noticing the version downgrade when updating to Rails 7.2. @binarylogic, is there anything further stopping a new gem release with the Rails 7.2 and 8 support? Right now bundle downgrades the gem to version to 3.4.2 which must have been the last version with a looser (or no) rails decency requirement.

brendon avatar Feb 13 '25 21:02 brendon

@binarylogic Similar to the last comments, I'd like to know if anything is preventing the release of a new gem version and if we can help in any way since it was merged almost two months ago, and the current documentation wrongly implies support for Ruby 7.x and 8.x:

image

aitor avatar Feb 21 '25 12:02 aitor

Just an FYI for anybody that missed it, this was released in Version 6.5.0. Thank you to all for getting this merged in and released. 🙏

joshuapinter avatar Aug 18 '25 18:08 joshuapinter

No worries! :) It loads much nicer now too which is good :)

brendon avatar Aug 18 '25 21:08 brendon