seal icon indicating copy to clipboard operation
seal copied to clipboard

Seal ignores PRs with the same title

Open suzannehamilton opened this issue 8 years ago • 1 comments

If you have several pull requests with the same title (e.g. because you've fixed the same issue in different projects), the seal only reports one of them.

I suspect this is because GithubFetcher returns a hash of the PRs with the title as the key. Line 26:

pull_requests[pull_request.title] = present_pull_request(pull_request, repo_name)

suzannehamilton avatar Feb 21 '17 10:02 suzannehamilton

We fixed the duplicate title issue with pull requests by changing that line to:

pull_requests["#{pull_request.title} (#{pull_request.number})"] = present_pull_request(pull_request, repo_name)

https://github.com/LiveWorld/seal/commit/5a32be26c90c3888dbbc4b9de49a691169fd0dbb

strangeminds avatar Apr 23 '19 15:04 strangeminds