binance-futures-connector-python icon indicating copy to clipboard operation
binance-futures-connector-python copied to clipboard

Batch cancel order not encoding parameters properly

Open raul-dan opened this issue 3 years ago • 3 comments

Though reported in #15 and closed as fixed, it is in fact still not encoding the query strings properly. I'm using 3.1.1 and the final query strings is still invalid:

[2022-06-02 08:44:58,565: DEBUG/ForkPoolWorker-8] https://testnet.binancefuture.com:443 "DELETE //fapi/v1/batchOrders?symbol=BTCUSDT&origClientOrderIdList=61cb41a6-a0b9-43d1-93d1-2a9050ae61cd&origClientOrderIdList=94e24acf-c3ba-4045-b359-1c9d3b7d75fd&origClientOrderIdList=dbd364ff-cf33-43a1-be48-1155c536e2f0&timestamp=1654159497710&signature=beaf2c54f6e3f23befdbc5661f97ea90d0992fa0b7f91c103d5c035f364e2eec HTTP/1.1" 400 84

raul-dan avatar Jun 02 '22 08:06 raul-dan

yes. I am facing the same issue

encoded_string: {'symbol': 'LRCUSDT', 'orderIdList': [14460401649, 14460401648], 'recvWindow': 2000, 'timestamp': 1657542266783}

query_string: symbol=LRCUSDT&orderIdList=14460401649&orderIdList=14460401648&recvWindow=2000&timestamp=1657542266783, special: False

xiandong79 avatar Jul 11 '22 12:07 xiandong79

@andrea-c-binance

xiandong79 avatar Jul 11 '22 12:07 xiandong79

yes. I am facing the same issue

encoded_string: {'symbol': 'LRCUSDT', 'orderIdList': [14460401649, 14460401648], 'recvWindow': 2000, 'timestamp': 1657542266783}

query_string: symbol=LRCUSDT&orderIdList=14460401649&orderIdList=14460401648&recvWindow=2000&timestamp=1657542266783, special: False

client.cancel_batch_order(symbol=symbol, orderIdList=str(limit_lists), origClientOrderIdList=None)

))) but this bug still needs to be fixed.

mcsham avatar Jul 28 '22 14:07 mcsham

Fixed in #51

chairz-2 avatar Aug 23 '22 05:08 chairz-2