binance-connector-python icon indicating copy to clipboard operation
binance-connector-python copied to clipboard

mypy support

Open RichardFevrier opened this issue 3 years ago • 3 comments

Hello everyone 👋

It should be great if this library could pass the mypy (--strict) static typing checker ✅

Thanks

RichardFevrier avatar Jun 20 '21 13:06 RichardFevrier

thank you for your suggestion, we will look into this. We are trying to keep this library simple, clean, and easy to use. Will not have a dependency unless it's very neccessary.

2pd avatar Jun 21 '21 03:06 2pd

What Richard is really requesting is for this project to have type hints so that mypy can do static type checking of this library and projects using it. Type hints are a built-in feature of Python since 3.5, so no extra dependencies needed, and considering 3.6 is the oldest still supported version of Python it's pretty safe to include type hints.

mypy is a development software just like flake8, so it won't be needed by users.

An-dz avatar Jul 11 '21 21:07 An-dz