react-native-image-cache-hoc icon indicating copy to clipboard operation
react-native-image-cache-hoc copied to clipboard
verified publisher icon billmalarky

Update documenatation to clarify cacheFile

Open jdmunro opened this issue 6 years ago • 1 comments

I noticed that .cacheFile doesn't respect the fileDirName that's been set in the options. This means that you might end up downloading the file twice, and can break certain offline solutions. This caught me out for a while so figured it was worth adding to the docs.

A future improvement would be to unify the two so that fileDirName is respected in both cases.

See this line, where no options are passed: https://github.com/billmalarky/react-native-image-cache-hoc/blob/master/lib/imageCacheHoc.js#L60

jdmunro avatar Feb 07 '19 18:02 jdmunro

Coverage Status

Coverage remained the same at 93.548% when pulling f3492bf8563c34a02509a8d81610df98218cec11 on jdmunro:master into 20c438a62c5997e8e5bc673abeedf63f6fbb1321 on billmalarky:master.

coveralls avatar Feb 07 '19 18:02 coveralls