Bill Lynch
Bill Lynch
> @billjive if you rebase, I can add the GitHub-based workflow to your branch! Great! Thanks everyone for the feedback, good suggestions. I can get this going in a day...
> @billjive if you rebase, I can add the GitHub-based workflow to your branch! Ok -- all rebased. I also split up the quirks tests in to 3 (well, now...
@rmondello thanks -- it's been a while so yes I'm sure it needs to be rebased. I'll figure out too if there are too many dependencies, not sure at the...
@rmondello I posted details here: https://github.com/apple/password-manager-resources/issues/98#issuecomment-671488154
> > * Single line if conditions are lacking braces. Did we forget [goto fail?](https://nakedsecurity.sophos.com/2014/02/24/anatomy-of-a-goto-fail-apples-ssl-bug-explained-plus-an-unofficial-patch/) > > This is a holdover from the WebKit project’s style. I’d agree with you...
> > * no unit tests > > I have a test suite written for the parser, but I haven’t figured out how to make it or something like it...
I created a quick version of this, you can [see it in my fork](https://github.com/billjive/password-manager-resources/commit/0cc55c73f73ca3d087cc13c91566d8acfb2205d0).
@rmondello I thought I'd post an update here rather than starting a new issue. I have a couple of examples of finished test that convert your Ruby suite to Javascript....
@rmondello or anyone else -- any interest in this?