Bill Denney
Bill Denney
> I think all the demanded changes were implemented. The tests should also be complete. I added additional arguments to control the specific behavior of the functions: > > `new_rows_after_original`...
I think that we should remove imputation first when duplicated and then put it at the location requested. In general, the imputation method order should not cause conflict in real...
Currently, the exclusion is only setup based on r-squared and not adjusted. It's a good suggestion to add, so I will do so.
Yep, that's a perfect work-around. The final solution within the package will look very similar to that (with more documentation, tests, etc.).
@Gero1999, Thanks for this discussion. I would typically recommend that users indirectly impute these concentrations so that IV-related parameters are correctly calculated. Is that your goal or do you have...
As I'm looking at #352 and #353, the IV NCA calculations do not work the way that I would like them to. I'm updating those now. I think that those...
As I thought more about it yesterday, I agree that these are useful. I have provided some code review comments in the PR. Thanks for contributing! Please also add your...
Make sure that imputation is covered within the solution, too.
It looks like the underlying issues are changes in the `gghalves` library. @kestrel99, I don't know this part of `pmxTools`, but I made some updates in #34 that take the...
> * `pk.calc.sparse_auc` has a `method` argument that is not used, because the method for `pk.calc.auc` is always fixed to linear This is semi-intentional. It is intentional in that it...