Bill Rich comments

Results 20 comments of


                                            Bill Rich

`vsan_disk_group` in `r/vsphere_compute_cluster` should be `TypeSet` and not `TypeList`

You are right on this. I'll get on fixing this and adding an acceptance test for it also.

Improve support for content library

Hi @stobias123! Many of those capabilities were added to govmomi after Content Library was implemented in the Terraform provider. I would very much like to add those features though. I've...

Add support for VM Encryption

Hi @surajsub! We don't currently have it on the road map, but I believe it is a feature we will likely implement in the future. I'll leave this issue open...

Add support for VM Encryption

This will likely be implemented along with VBS in #677

Linked clones depend on `template_uuid` instead of `snapshot_id`

Thanks @rickhlx! This is an excellent suggestion. Adding a `snapshot_id` would help with several `clone` related improvements. We'll need to look more closely at if there would be any unexpected...

Fix typo in exception message when attempting to open a repo

I'm going to close this PR because this has been fixed elsewhere.

URI Detector Returning False Positives

I did some testing with this and wasn't able to reproduce the issue. As long as the full URL with creds doesn't return a 2xx code, it shouldn't be marked...

Partially revert #2253

@ahrav How does this mesh with the #2253 changes?

Secrets are reported on the wrong line

The reason for this is that `filesystem` doesn't do any special chunking. Git-based sources maintain line numbers through chunking in the `git` source which does its own line-aware chunking. We...

Add test case to gitparse that previously caused a panic

Tested and the #1570 fix handles this. It looked to me like it shouldn't miss anything at first glance. If `currentDiff` is `nil`, then it shouldn't be able to exceed...