flatwhite-syntax icon indicating copy to clipboard operation
flatwhite-syntax copied to clipboard

Zed version of the theme

Open osdiab opened this issue 1 year ago • 5 comments

Zed supports background colors for syntax highlighting, would love to use Flatwhite on this new school editor 😎

osdiab avatar Aug 19 '24 07:08 osdiab

Just tried and checked the json schema for themes, Zed still doesn't support different background colors for syntax highlighting :(

bobuk avatar Nov 27 '24 17:11 bobuk

@bobuk https://github.com/bIaqat/flat-theme-zed does exist, but it's currently broken: selecting text does not change the background of a syntax highlight span.

klemola avatar Nov 28 '24 08:11 klemola

I'm currently started using Zed myself but was under impression that it doesn't support background colors for syntax highlightning. @klemola thanks for example, really curious how it works. Will have a look.

biletskyy avatar Nov 29 '24 08:11 biletskyy

@klemola oh thank you. My quick research shows that zed themes json schema is wrong :) HighlightStyleContent shows only three supported fields: color, font_style, and font_weight. Author of flat-theme-zed used background_color and it's working like a charm. In the code its clear that it's just a error in json schema. So YES, flatwhite can be ported to zed at least partially

bobuk avatar Nov 29 '24 14:11 bobuk

please note, that latest Zed release fixes the problem: https://zed.dev/schema/themes/v0.2.0.json

HightlightStyleContent officially have background_color.

@biletskyy if you're working on porting, I'm 100% ready to test or to help with something.

І дякую за роботу, багато років і мегабайти мого коду були хороші завдяки flatwhite.

bobuk avatar Dec 03 '24 19:12 bobuk