flatpak-vscode icon indicating copy to clipboard operation
flatpak-vscode copied to clipboard

No Flatpak manifest found in this workspace

Open jeffshee opened this issue 3 years ago • 5 comments

Hi, Thanks for developing the extension. I'm new to Flatpak. (Sorry if this issue is not an issue at all.)

I created a HelloWorld Flatpak by following Flatpak's documentation. I can build and run the Flatpak by using flatpak-builder. However, I couldn't use the extension to do anything Flatpak-related. The extension seems couldn't detect the manifest, which as you can see there is manifest in the workspace. I even tried with both JSON and YAML, but nothing helped.

Screenshot from 2022-08-31 20-45-34

(I think we need some documentation for beginners...)

jeffshee avatar Aug 31 '22 11:08 jeffshee

That may be the checks being too nitpicky, can you paste the manifest here?

SeaDve avatar Aug 31 '22 12:08 SeaDve

@SeaDve Sure.

JSON

{
    "app-id": "io.jeffshee.Test",
    "runtime": "org.gnome.Platform",
    "runtime-version": "42",
    "sdk": "org.gnome.Sdk",
    "command": "hello.sh",
    "modules": [
      {
        "name": "hello",
        "buildsystem": "simple",
        "build-commands": [
          "install -D hello.sh /app/bin/hello.sh"
        ],
        "sources": [
          {
            "type": "file",
            "path": "hello.sh"
          }
        ]
      }
    ]
  }

YAML

app-id: io.jeffshee.Test
runtime: org.gnome.Platform
runtime-version: '42'
sdk: org.gnome.Sdk
command: hello.sh
modules:
  - name: hello
    buildsystem: simple
    build-commands:
      - "install -D hello.sh /app/bin/hello.sh"
    sources:
      - type: file
        path: hello.sh

jeffshee avatar Aug 31 '22 12:08 jeffshee

Thanks! I tried debugging and somehow adding a "finish-args": [] entry makes it detect it.

SeaDve avatar Aug 31 '22 12:08 SeaDve

finish-args is required in general, i don't think you can do much without it...

bilelmoussaoui avatar Aug 31 '22 12:08 bilelmoussaoui

I think it might be good to have a fallback option in case the check had failed. For example, manually mark the JSON/YAML files as Flatpak manifest, and bypass the checking.

jeffshee avatar Sep 01 '22 23:09 jeffshee