Bilal Elmoussaoui

Results 998 comments of Bilal Elmoussaoui

Can't you combine both this action with another one to do the uploading ? i saw you opened a PR but then closed it and went with a fork...

Yes it would need more changes. Patches are welcome.

can you please rebase?

> @bilelmoussaoui Please check the GDK4/GTK4 changes, everything else is fine. Just press the button when you've done that :) They are not fine :p we need a patch to...

It would be less work to fix gir btw, you need to add a condition here https://github.com/gtk-rs/gir/blob/main/src/codegen/flags.rs#L102 and here https://github.com/gtk-rs/gir/blob/main/src/codegen/enums.rs#L145 that would automatically prefix the name with _ if it...

Well, the g-ir-scanner that produces the GIR files must complain that the code is potentially not bindings friendly. In any case, please send a patch so you don't have to...

> Anything else we should know? https://github.com/flatpak/xdg-desktop-portal/pull/1521 may be relevant here. Exactly. If you use that, you would end up with a different key. If the app is not sandboxed,...