Hardcode-Tray icon indicating copy to clipboard operation
Hardcode-Tray copied to clipboard

Apps are only applying for light theme (dark icon)

Open hrqmonteiro opened this issue 2 years ago • 3 comments

Specifications

  • Hardcode-Tray version : `` latest
  • Distribution : `` Fedora 37
  • Gtk version : `` 4
  • Inkscape version : `` latest
  • Cairo version : `` latest
  • Sni-qt version: `` latest
  • Application name : `` Joplin, Discord, Steam (not working)
  • Application version : `` latest

Expected behavior and actual behavior

Themes are only applying for light theme (dark icon)

Steps to reproduce the problem

Just trying to apply using Papirus theme, the icons are patched correctly but only uses the dark icons (light theme)

On a dark wallpaper it's impossible to see it: Screenshot from 2023-04-15 17-30-17

Here's on a light wallpaper: Screenshot from 2023-04-15 17-31-56

So how can i properly apply the Papirus Dark and Light icons?

hrqmonteiro avatar Apr 15 '23 20:04 hrqmonteiro

This is very strange, even if i pass Papirus-Dark to BOTH themes, like so:

sudo -E hardcode-tray --conversion-tool Inkscape --light-theme Papirus-Dark --dark-theme Papirus-Dark --only joplin

It still changes to a dark icon:

Screenshot from 2023-04-15 17-44-14

Why??

hrqmonteiro avatar Apr 15 '23 20:04 hrqmonteiro

Try this...

sudo hardcode-tray --apply --theme Papirus-Dark

It's working great here with all converted icons, I'm using Kubuntu.

rauldipeas avatar May 11 '23 12:05 rauldipeas

Try this...

sudo hardcode-tray --apply --theme Papirus-Dark

It's working great here with all converted icons, I'm using Kubuntu.

You probably are not getting what i am saying, my man.

If i apply --theme Papirus-Dark, then all of the icons will be white, of course.

What i meant is thatt, when you apply both --light-theme and --dark-theme, it should be theme-aware, right? If ai am on a dark theme, it should use the icons applied on --dark-theme, if i am on a light theme, it should use icons applied on --light-theme. But it doesn't.

If i apply like i said, all of the icons are from the --light-theme.

hrqmonteiro avatar Oct 14 '23 12:10 hrqmonteiro