Christoph Buchner

Results 644 comments of Christoph Buchner

* [ ] See if we can store (at least for a short time) the generated documentation (~1 MB) as an artifact so we can check online if docs generation...

* [ ] Upgrade GH actions plugin version to 3: https://github.com/actions/cache/releases/tag/v3.0.0

* [ ] We could start adding pydocstyle checking to CI. Enable "D212 | Multi-line docstring summary should start at the first line"

Where does that error occur? Can you step through your code in a debugger or console. When instantiating the instrument, can you pass `read_termination` and `write_termination` as appropriate for the...

I think you'll have to read up what that error means, exactly. What you can also do is manually execute [the things](https://github.com/pymeasure/pymeasure/blob/1a94492585d06ae6b55992f71f3213db638e7412/pymeasure/instruments/keithley/keithley2400.py#L390-L404) `measure_voltage` does to nail down which command exactly...

I'll let @CasperSchippers handle this as I'm not too familiar with the GUI code, but in principle refactoring is good if it improves the structure and in the end yields...

Better [connection configuration ](https://pymeasure.readthedocs.io/en/latest/dev/adding_instruments.html#defining-default-connection-settings)(needs to be tested with hardware) I see no reason to force use of `SerialAdapter` here, so let's use the preferred VISAAdapter approach: ``` def __init__(self, port,...

As for the set of default SCPI methods: this was before my time, could be nobody needed that before. But I agree, if it's a standard SCPI command it should...

> as far as I understand pandas does support handling of metadata now? Indeed, with 1.0, pandas [learned](https://pandas.pydata.org/pandas-docs/stable/reference/frame.html#metadata) `Dataframe.attrs` to store metadata (still marked experimental).

Your logic seems messed up a bit: ``` for cycle in range(1,4): for i in range(3): rows = [[i, i + n] for i in range(3)] df = pd.DataFrame(rows, columns=["A",...