Christoph Buchner

Results 644 comments of Christoph Buchner

> Therefore, we need at least two environments. If we continue maintaining two test envs (and numpy and other dependencies that follow https://numpy.org/neps/nep-0029-deprecation_policy.html will force us to), let's call them...

> Either we keep two Environment with different Numpy versions (some hasse, but manageable) or we unpin Numpy Version. > > I tend mildly to the latter. Due to the...

> We do not use numpy that much and then only for a few small calculations or parsing of binary data, so I do not expect failing tests due to...

> And downgraded sphinx (to a version compatible with Python 3.9) does not work with the docs... Isn't this just because of that warning > WARNING: Calling get_html_theme_path is deprecated....

`value_render = f"{value_render:.{self.float_digits:d}g}"` wow it did not occur to me to nest {} in f-strings like that. :-P, the inner one probably could be factored out into a variable. But...

> I limited the numpy version to the previously used one, such that the tests continue to pass, until #713 is fixed. Agreed. We should make sure to fix that...

The original reason was a user request for a more accurate/precise version (e.g. when living on pymeasure master branch and working in notebooks, if I remember correctly). That we do...

> I do not see, how they could profit from the pymeasure instrument core, nor how we could test or maintain them reliably. > Therefore, I do not like the...

> is that you have a separate repo with no maintainer, the barrier of contributing something to that repo might be a bit higher (if that would mean that the...