Christoph Buchner

Results 483 comments of Christoph Buchner

FWIW, pymeasure is also two things in one package - the GUI/procedure stuff and the instrument drivers (the latter are largely independent from the former).

I am not opposed to the proposal on principle, and for sure reducing duplication would be very attractive. My assessment is driven by a couple of different experiences. On ALC:...

In #453, we had a detailed discussion [starting here](https://github.com/pymeasure/pymeasure/pull/453#discussion_r650675731_) about how to improve the abstraction regarding SCPI features with `includeSCPI`. As this is intricately connected to this issue concerning the...

https://hynek.me/articles/python-subclassing-redux/ : A long essay on subclassing techniques/ design patterns, worth the read to expand your horizon, or even to only put names to things you have seen before. To...

Further pointers, to a set of generic base classes in InstrumentKit: https://instrumentkit.readthedocs.io/en/latest/apiref/instrument.html#instrument-base-classes https://instrumentkit.readthedocs.io/en/latest/apiref/generic_scpi.html Could be useful as a source of inspiration, in my experience the IK are quite thorough regarding...

It looks to me, also re: #580, that it would probably make sense to sublass `Instrument` to `SCPIInstrument` (for the SCPI-only properties), and then derive `GenericSCPIPowersupply` and other classes from...

One thing we can/should also resolve while we're at it is channel implementations: How do we account for channels in the generic instruments? Do they all have 1 channel in...

I agree that this issue is worth implementing. With #376 merged we are also in a much better place to deal with instrument differences than before. However, I'm afraid I...

Oscilloscopes might be a good early candidate for harmonization, the LeCroy T3DSO120 (#697), Keysight DSOX1102G and Tektronix AFG3152C `Channel` objects are quite similar/derived from each other. cc @LastStarDust

From the way the gridlines are also messed up - maybe this is a pyqtgraph problem? Is your version up to date? Aside of that, no idea.