Christoph Buchner
Christoph Buchner
> Generally speaking, in python, one can mess up the inheritance tree quite significantly, since one class can inherit from multiple classes which can each inherit from "whatever" On the...
> Now I am not sure which approach you named "adpater mixin". sorry about that >.< Thank you for compiling a summary with named alternatives! With "adapter mixin" I meant...
Ah, great! In fact there were some initiatives to get frame-based communication going. See #296, #239, #437, especially [this conversation](https://github.com/pymeasure/pymeasure/pull/239#discussion_r386124016). I want to get that in in a way that...
Great, thanks! Yeah, that's actually what I meant (sorry for being imprecise) - not SCPI-compliant (e.g. not implementing the standard commands) is fine; I consider instruments exchanging "commands" (either ascii/plaintext...
Also check [this out](https://pyvisa.readthedocs.io/en/latest/api/resources.html#pyvisa.resources.RegisterBasedResource) - might be useful. It would be fine for me if we restrict the frame-based Adapter to using pyvisa/inherits from the VISAAdapter if that makes our...
This ask() implementation was added in aba03d216606d3ed7e5f7c98e7cf30d70f2371b2 (#33) and half-fixed in 161aa8a8fc3421745eb5eec325c599c501707e9d (#48), both by @cjermain. I think the fix is straightforward, but this shows impressively that this instrument was...
* [x] Make VISAAdapter.ask also use our own write and read instead of delegating to pyvisa.query. This makes it easier to be homogeneous across adapters, and also enables cleaner use...
#621 adds an instrument that would also profit (i.e., eliminate duplication) from having a unified `ask` method.
@CasperSchippers thanks for the detailed review, I only now get to this in my backlog! :bow:
waiting for resolution of #659 before adapting/including this.