ViewImage icon indicating copy to clipboard operation
ViewImage copied to clipboard

Upgrade to Manifest V3, reduce errors, tune permissions

Open funblaster22 opened this issue 2 years ago • 2 comments

Upgrade manifest v3: Renamed entries in manifest

Reduce errors: Add onInstalled listener, which fixes Unchecked runtime.lastError: Cannot create item with duplicate id ViewImage-SearchByImage

Tune permissions: Replace tabs with activeTab permission, which do longer prompts permission every time

funblaster22 avatar Jun 09 '22 22:06 funblaster22

Hi @funblaster22 thanks for doing this, I'll take some time tomorrow to review this, just a note for now this would likely be shipped as v4 since moving manifest version imo is breaking enough. so might be worth changing that once you've got time!

bijij avatar Jun 14 '22 11:06 bijij

Ok, I bumped the version but accidently made a merge conflict in the process sorry 😞

funblaster22 avatar Jun 20 '22 23:06 funblaster22

@funblaster22 Since manifest V3's pretty much ready for firefox I'll take some time to look into merging this in in the coming weeks. Thanks again for doing this!

bijij avatar Oct 27 '22 14:10 bijij

in in the coming weeks

;)

Saibamen avatar Jul 05 '23 07:07 Saibamen

This was manually rebased to handle support for Firefox. Thanks for this.

bijij avatar Jul 17 '23 08:07 bijij