ViewImage icon indicating copy to clipboard operation
ViewImage copied to clipboard

Clicking "View image" opens blank page

Open f4ringo opened this issue 4 years ago • 20 comments

I see blank page when I'm trying to open full size image

Steps

  1. Open any image in Google
  2. Click "View Image"
  3. See blank page

Pics 1. image

  1. Opens this image

–––––––––––––––– Mac OS Catalina Chrome 76.0.3809.132 ViewImage v3.2.2 (mac x86-64) - ru

f4ringo avatar Jan 28 '20 10:01 f4ringo

Same issue occurring for me. I assume Google changed something in the last few days.

MacOS Catalina 10.15.2 Chrome 79.0.3945.130 v3.2.2 (mac x86-64) - en_US

JustusGS avatar Jan 29 '20 16:01 JustusGS

Yeah - me too - on all platforms. Looks like Google did something.

SteveBaker avatar Jan 31 '20 23:01 SteveBaker

At the moment I can't repro unfortunately. likely A:B testing on Google's end 😞

bijij avatar Feb 02 '20 10:02 bijij

@bijij I can confirm the issue. It looks like google is creating some temporary container with base64 image and then swaps it with new container which contains the image from real URL. But not always - if you switch image below preview (in right pane), then it just swaps img src attribute. Using mutation observer on the .n3VNCb (which are image previews) attributes seems to be reliable in both cases.

Please can you test this fixed version on your end? I wonder whether class tvh9oe was already present in OCT19 or we need to split it into JAN20. Sorry for not creating PR, too much hassle for one file when I don't know if works for everyone. :/

https://pastebin.com/h5GgVUnH

Tested in chrome and FF.

ikeblaster avatar Feb 02 '20 11:02 ikeblaster

This seems to work for me, I'm not sure if tvh9oe always existed or not.

I'll be happy to commit this and push a new version if you're okay with that.

bijij avatar Feb 02 '20 12:02 bijij

sorry @ikeblaster forgot to mention you.

bijij avatar Feb 02 '20 12:02 bijij

@bijij Of course, please do.

ikeblaster avatar Feb 02 '20 14:02 ikeblaster

Gone ahead and published a copy with those changes, lets see if it fixes it for people.

bijij avatar Feb 03 '20 08:02 bijij

@bijij I don't see any updates. Is it not published yet on the addon store?

Reonu avatar Feb 04 '20 10:02 Reonu

@Leon422 what version is your extension currently?

bijij avatar Feb 04 '20 11:02 bijij

@bijij v3.2.2 (win undefined) - undefined. I'm on Firefox. The addon store says the extension was last updated 3 months ago.

Reonu avatar Feb 04 '20 11:02 Reonu

@Leon422 I repushed to AMO should be live in a bit.

bijij avatar Feb 04 '20 11:02 bijij

@bijij It finally updated, and it's working fine again. Thanks!

Reonu avatar Feb 04 '20 12:02 Reonu

Thanks! It's working!

MrNotSoNice avatar Feb 04 '20 18:02 MrNotSoNice

Thanks @bijij It’s working!

f4ringo avatar Feb 04 '20 18:02 f4ringo

It still shows the thumbnail if you click view image for larger images where only the thumbnail loads

needforsuv avatar Feb 06 '20 09:02 needforsuv

if the main image isn't one of the main ones

needforsuv avatar Feb 06 '20 09:02 needforsuv

I'm using v3.2.2 of the UserScript version on Chrome 81.0.4044.43, and this is still broken.

tsuliwaensis avatar Mar 08 '20 05:03 tsuliwaensis

This issue is still the case and seems to be occurring more frequently

JohannesMP avatar Jan 26 '22 13:01 JohannesMP

The 'Google Images Restored' extension appears to not suffer from this issue - https://chrome.google.com/webstore/detail/google-images-restored/ncndcebmkibkhopclfdjfacgfholcghi/related

Specifically for a given image result where with the 'View Image' extension exhibits this bug, viewing the same search and having the same search result with the 'Google Images Restored' extension installed will not cause this bug, and all images seem to both render their previews as well as as open the image as desired.

For the time being I would therefore recommend anyone that is encountering this issue with the 'View Image' extension to consider 'Google Images Restored' instead.

JohannesMP avatar Jan 26 '22 14:01 JohannesMP