sentence-breaker icon indicating copy to clipboard operation
sentence-breaker copied to clipboard

Single quotes

Open dinamic opened this issue 4 years ago • 2 comments

Just found out that single quotes are not always processed properly.

Consider the following sentences:

  • I'm 5'10
  • I'm '90s kid

The first one works, while the second one does not and fails with the following message:

Failed to find end of quote. Reached end of input. Read: '90s kid

It looks like it's trying to find a pair for the single quotation, but there isn't any.

dinamic avatar Mar 18 '20 16:03 dinamic

Hey @bigwhoop, do you think there's a workaround for this one?

dinamic avatar Apr 01 '20 09:04 dinamic

@bigwhoop the example above seems to be handled now, but there are some other cases that fail still. Here are a few:

This one fails 'cause is not handled Hit 'em up!

dinamic avatar Jan 25 '22 17:01 dinamic

Seems like that may be covered in https://github.com/bigwhoop/sentence-breaker/issues/5

scotteuser avatar Oct 07 '24 07:10 scotteuser