BIGTREETECH-TouchScreenFirmware icon indicating copy to clipboard operation
BIGTREETECH-TouchScreenFirmware copied to clipboard

Published 20 hours ago • verified publisher icon bigtreetech

Buzzer - No polling

Open kisslorand opened this issue 1 year ago • 2 comments

Requirements

BTT or MKS TFT

Description

This PR implements buzzer control purely interrupt base. There is no more polling anymore if there is any sound to play or not, everything is done by the interrupt, it's set and forget.

Benefits

  • more consistent sound patterns and no interference with the other tasks
  • a little speed boost for the TFT (do not ask for numbers, it differs across the TFT range)

Related Issues

Implements feature request #2845

Notes

It has been tested on all MCUs involved in this FW. Beeps nicely :) ~This PR might be updated with PWM approach if it will prove to be beneficial.~

kisslorand avatar Sep 27 '23 21:09 kisslorand

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 15 '23 06:12 stale[bot]

This PR has been automatically marked as stale because it has had no activity for the last 60 days. It will be closed in 7 days if no further activity occurs. Thank you for your contribution.

github-actions[bot] avatar Apr 20 '24 01:04 github-actions[bot]