Salvatore Ingala

Results 100 comments of Salvatore Ingala

> The fallback transaction serves as an ownership proof WRT the sender's inputs in the sender's original PSBT, and the partially signed payjoin PSBT with which the receiver replies covers...

I will look into the CI asap. UPDATE: fixed the obvious ones; `script_tests` fails as only functional tests have currently been updated, so that remains to be done.

Renamed the `flags` parameter to `mode`, matching the analogous change in the BIP draft. Rebased to the latest master. Still trying to locally reproduce the unit test failures.

I added a workaround to disable the two failing tests from the `script_assets_test`; those tests do indeed assume the `OP_SUCCESS` behaviour of the `0xBB` opcode.

In dfa26453fb1975c0c8b7909e8237a5ac55f4dd8c, I added the possibility of using unhardened derivation steps in the key origin information (while keeping the restriction for `change`/`address_index` in the key placeholders). While most wallets use...

Thanks @jgriffiths and @bucko13 for the reviews! I addressed most of the comments in da3e117d075f4428f14d4120124d840682e5587d. In bb98f8017a883262e03127ab718514abf4a5e5f9 I deleted the examples coming from HTLC miniscripts; they don't quite make sense...

> * Descriptor is equipped with prefix and suffix containing information to reconstruct all shared key components: `wsh/testnet(...)//*#checksum` > * Keys do not list shared components, skipping them: `[f149e757//0h]xpub` (where...

Thanks for the update, @jgriffiths! I added Jade/libwally support in 3c97885, and did a couple of small improvements to the python demo.

@luke-jr, please let me know if this can be assigned a BIP number, or if something is missing. There are now three hardware signers already using these specs in production.

I squashed the history, rebased and updated BIP number and type in 3bb2cfe4751313470b98c9aaaff9322078fb8e3c d4c650bad3ac190c9106d059b1ed5b110f2660bb.