intercooler-js
intercooler-js copied to clipboard
bigskysoftware
Create ic-disable-inputs attribute
On a request we closestAttrValue('ic-disable-inputs') of the element submitting. If it is true, we search for all inputs below that element and disable them.
Then you could put ic-disable-inputs on a form and have it disable all input elements below, put it on a single input, etc.
I'm a little worried that this would cause a big change in behavior. Maybe it would be OK if the element type were verified?
Can I ask that this be reworked and expanded a bit?
I think the right behavior is to add a new attribute: ic-disable-inputs="true"
On a request we closestAttrValue('ic-disable-inputs') of the element submitting. If it is true, we search for all inputs below that element and disable them.
Then you could put ic-disable-inputs on a form and have it disable all input elements below, put it on a single input, etc.
Does this sound reasonable?
I also would like a test for this if possible.
for the hack October https://hacktoberfest.digitalocean.com/ i will working with this!
awesome 👍
On Oct 5 2019, at 10:44 am, Andres Vargas [email protected] wrote:
for the hack October https://hacktoberfest.digitalocean.com/ i will working with this!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://github.com/intercoolerjs/intercooler-js/pull/284?email_source=notifications&email_token=AADSRP47UZKUI5XRCIWNT2LQNDHBVA5CNFSM4HJ24BT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANX2DQ#issuecomment-538672398), or mute the thread (https://github.com/notifications/unsubscribe-auth/AADSRP7O3MK7PPJSWAODVWLQNDHBVANCNFSM4HJ24BTQ).
@zodman I'm planning on doing a realase at the end of hacktober, let me know if you need any help or encouragement getting this done. I think it is a good feature!