htmx icon indicating copy to clipboard operation
htmx copied to clipboard

Dark theme

Open tunguski opened this issue 3 years ago • 4 comments

Just a proposal. Let me know what do you think.

tunguski avatar May 30 '22 11:05 tunguski

Can you post a screenshot?

1cg avatar Jun 02 '22 19:06 1cg

Screenshots (Firefox)

Main page

main_page_dark

Reference

reference_dark

Documentation

docs_dark

tunguski avatar Jun 02 '22 22:06 tunguski

I like the idea of supporting @media (prefers-color-scheme: dark) { for people who don't have something like Dark Reader installed.

The color selections here are a little over saturated, and the gradient should probably be removed, but the fundamental idea is sound.

gnat avatar Jun 18 '22 15:06 gnat

Sorry I let this sit so long. I think I'd prefer a black background to blue for a dark mode. Is that doable? (my design-fu is awful, of course)

1cg avatar Sep 30 '22 20:09 1cg

@tunguski unfortunately, we did a website refactor pretty recently and removed the scss files entirely. Are you interested in rebasing this PR against the current website build?

alexpetros avatar Jul 17 '23 05:07 alexpetros

image

gnat avatar Jul 17 '23 05:07 gnat

@gnat is this your way of saying we have a dark mode already and I can close this PR?

alexpetros avatar Jul 17 '23 14:07 alexpetros

That's Dark Reader extension. I recommend it as an interim solution (..although I imagine most devs desiring lower brightness already are aware :wink:)

First impressions really do count.. so if we're "taking over" this responsibility, it has to look good (dark reader's design is good enough IMO). Everyone who has wanted to contribute a dark mode so far has "programmer art" design sensibilities (sorry OP, but it is a good idea!)

The site will get one eventually but short term I recommend dark reader extension. If it's a worse dark mode than dark reader, we need to avoid it.

gnat avatar Aug 09 '23 02:08 gnat