htmx icon indicating copy to clipboard operation
htmx copied to clipboard
verified publisher icon bigskysoftware

Triggerspec delay unique

Open jsonn opened this issue 1 year ago • 3 comments

Description

If a node has multiple trigger specifications, they should have independent delays. If a single delayed trigger specification is targets multiple nodes, they should share the delay.

Corresponding issue: #2892

Testing

Both variants are explicitly tested. The non-sharing of multiple trigger specifications failed before.

Checklist

  • [X] I have read the contribution guidelines
  • [X] I have targeted this PR against the correct branch (master for website changes, dev for source changes)
  • [ ] This is either a bugfix, a documentation update, or a new feature that has been explicitly approved via an issue
  • [X] I ran the test suite locally (npm run test) and verified that it succeeded

Note: the change is on top of #2891

jsonn avatar Sep 11 '24 13:09 jsonn

Hey, you'll want to retarget to dev as per our contribution guidelines

Telroshan avatar Sep 12 '24 09:09 Telroshan

Hey, you'll want to retarget to dev as per our contribution guidelines

It was, stupid GitHub UI always chooses the wrong base here.

jsonn avatar Sep 12 '24 10:09 jsonn

Thanks!

Note: I'm labelling this as "under discussion" until https://github.com/bigskysoftware/htmx/pull/2891 is processed, as the latter includes some changes that this PR depends on.

Telroshan avatar Sep 13 '24 08:09 Telroshan

It looks like we merged the dependent PR, so if you want to rebase this, please do and re-open the PR.

alexpetros avatar Jul 22 '25 01:07 alexpetros