htmx icon indicating copy to clipboard operation
htmx copied to clipboard

fix(swap): apply swap delay in swap function instead of handleAjaxResponse

Open byteshinobi opened this issue 1 year ago • 1 comments

Description

moved application of swap delay to swap function so that the JS api can also use the swap delay

Corresponding issue:

Testing

manually tested in my local environment, both with the JS api and with normal hx requests

Checklist

  • [x] I have read the contribution guidelines
  • [x] I have targeted this PR against the correct branch (master for website changes, dev for source changes)
  • [x] This is either a bugfix, a documentation update, or a new feature that has been explicitly approved via an issue
  • [x] I ran the test suite locally (npm run test) and verified that it succeeded

byteshinobi avatar Aug 23 '24 18:08 byteshinobi

Hey,

  • You'll want to rebase against dev (not merge) to drop unnecessary commits that currently pollute your PR's diff
  • Could you add test cases for this? Thanks!

Telroshan avatar Aug 25 '24 07:08 Telroshan

Hey,

  • You'll want to rebase against dev (not merge) to drop unnecessary commits that currently pollute your PR's diff
  • Could you add test cases for this? Thanks!

Hey @Telroshan,

I've rebased and added a test that fails on dev and works on the bugfix branch

byteshinobi avatar Dec 27 '24 20:12 byteshinobi

Thanks! Took the liberty to add a link to this issue (opened in the extensions repo) to your PR description for other reviewers btw, as it's directly concerned by this suggestion!

Telroshan avatar Jan 06 '25 06:01 Telroshan

Any news on this getting merged as this fixes a problem I was having?

RobMaskell avatar Mar 10 '25 21:03 RobMaskell

i can accept this

1cg avatar Jun 02 '25 17:06 1cg

I've tested this from dev and it's working for swap delay, Thanks. @1cg There seems to be another PR raised recently that fixes this issue too (and others, like view transitions)

RobMaskell avatar Jun 04 '25 12:06 RobMaskell