htmx icon indicating copy to clipboard operation
htmx copied to clipboard

Minimize re-rendering of 'bulk update users' table

Open yawaramin opened this issue 1 year ago • 1 comments
trafficstars

Description

Use ARIA to announce a summary of the bulk update. By using a checkbox input to represent the activation status, we don't need to re-render it when it's changed, because the checkbox itself manages that state.

Corresponding issue: #1431

Testing

Tested manually by running Zola locally, verified behaviour works as intended.

Checklist

  • [x] I have read the contribution guidelines
  • [x] I have targeted this PR against the correct branch (master for website changes, dev for source changes)
  • [x] This is either a bugfix, a documentation update, or a new feature that has been explicitly approved via an issue
  • [x] I ran the test suite locally (npm run test) and verified that it succeeded

yawaramin avatar Jan 27 '24 06:01 yawaramin

This PR has had no activity for 30 days. It will be automatically closed in 7 days if there is no activity.

github-actions[bot] avatar Mar 09 '24 01:03 github-actions[bot]

This PR has been automatically closed due to inactivity. Feel free to re-open once activity resumes.

github-actions[bot] avatar Mar 16 '24 01:03 github-actions[bot]

If you want this merged you might need to share your dongle ID and a route with openpilot engaged

incognitojam avatar Mar 16 '24 14:03 incognitojam

Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:

  • Convert your PR to a draft unless it's ready to review
  • Read the contributing docs
  • Before marking as "ready for review", ensure:
    • the goal is clearly stated in the description
    • all the tests are passing
    • the change is something we merge
    • include a route or your device' dongle ID if relevant

github-actions[bot] avatar Mar 22 '24 02:03 github-actions[bot]

Dongle, platform, VIN Name from VIN 🆚 CarDocs Segments Bad seg tags Good seg tags
c5fc8ee4e8be2d97
SKODA_OCTAVIA_MK3
TMBLK7NE0........
None 🆚
None
140 routes,
2646 segments
(44.1 hours)
- car faulted: 27 - valid torque params: 2440
- all lat active: 593
- no input all lat active: 260

sshane avatar Mar 22 '24 03:03 sshane