David Precious comments

Results 88 comments of


                                            David Precious

make require_login and require_role available in the load_app

That would require hackery in Dancer's core itself, which I'm not sure is desireable. Personally, if you have multiple apps loaded and want to protect all requests based on the...

Failed test 'database_connection_failed hook fires'

> A few well placed prints shown that sometimes a non-expired handle is obtained from the previous connection, making the function return early without attempting to get a new one...

Failed test 'database_connection_failed hook fires'

So far, I've been unable to reproduce this. I've been running the test suite repeatedly in a tight loop, 500+ iterations so far and not a single failure, so I...

Failed test 'database_connection_failed hook fires'

Ooh - I _can_ reproduce it on my workstation box, but *very* rarely. With a serious thrashing, all 8 cores running in parallel, I recorded 2 failures out of 1504...

Refusing clobbering of {HandleError} installed on externally supplied DBI handle

Sorry for the slow response - looks like both Dancer::Plugin::Database and something else in your app are setting HandleError. Maybe Dancer::Plugin::Database should provide an option to disable the error hook...

RFC2: Core::Handle - make simple_query a little less simple

My initial reaction is "don't want to make the simple query stuff any more complicated at all, and I still in hindsight probably should have just had it wrap SQL::Abstract...

RFC2: Core::Handle - make simple_query a little less simple

Having had a little bit more of a think, it definitely needs some doco to explain how to use it etc, but it seems like a fairly sensible addition which...

Applying settings to database() at runtime does not reuse database connections

Hmm, sorry I managed to miss this one. Yes, agreed, we ought to work out a fix - serialising the hashref contents to generate a key sounds like the best...

Applying settings to database() at runtime does not reuse database connections

I finally had a chance to hack on this, and got part-way, but one fun problem: the settings may contain coderefs, e.g. HandleError, whatever serialisation form is used needs to...

Made named connections inherit their charset from the default(unless cha...

Sorry for the slow reply - this looks good, thanks! However, I'm wondering if it should be more generic, and copy everything from the top level (except the 'settings' key),...