Kevin McDermott

@eloo-abi Do you have any logs from the process, how long did it take? did it fail?

Hi @eloo-abi thanks for this, I've had a look, and it should wait for up to 30 seconds before timing out. But, I don't see any cases in your output...

@eloo-abi I'm reading the code to see if that could be the case, but I don't think so, it's basically waiting for the plan pending state to be populated. https://github.com/weaveworks/tf-controller/blob/main/tfctl/replan.go#L39-L54...

We need to figure out what fields we use, and where they've gone. We also want to continue to support the existing version, and the new(er) versions, we want to...

I've implemented a couple of different approaches here https://github.com/tektoncd/pipeline/compare/master...bigkevmcd:escape-strings-in-script One would escape everything in the `Script` element of the Task, the other would would require more explicit (using `#()`) escaping.

I'll summarise the options as I see them: On the triggers side: - Manual escaping (add a CEL function, perhaps `shellEscape()` on strings) - Automated escaping of data in TemplateBindings?...

Let me see if I can clarify what we think should happen from this. The values of _all_ params being output in tektoncd/pipeline should be escaped to be shell-safe?

@dibyom I think that would be the best solution :+1:

## Validation Template ## What was fixed, or what change has occurred LDAP search queries were failing with the following error message: `[WARNING] ldap search principals failed to get ldap...

@nickwsuse Can you clarify whether or not the Shibboleth installation on 2.8.3 is working _before_ the upgrade?