caminte icon indicating copy to clipboard operation
caminte copied to clipboard

Depricated code in Redis driver

Open xtremespb opened this issue 8 years ago • 4 comments

The code in Redis driver is deprecated. If there's no auth information for Redis server provided in config, the following warnings are shown in console:

node_redis: Deprecated: The AUTH command contains a "undefined" argument. This is converted to a "undefined" string now and will return an error from v.3.0 on. Please handle this in your code to make sure everything works as you intended it to. node_redis: Warning: Redis server does not require a password, but a password was supplied.

The fix is pretty simple, to change the following line (38) in adapters/redis.js:

schema.client.auth(schema.settings.password);

to

if (schema.settings.password) schema.client.auth(schema.settings.password);

I can try to make a pool request here when necessary.

xtremespb avatar Apr 08 '16 11:04 xtremespb

This is a pain, and highly needed. We don't have a password due to a bug within socket.io-redis and have decided to lock down our Redis via other security methods.

ellisio avatar Apr 18 '16 22:04 ellisio

I've fixed this issue in Pull Request #93

Hopefully it is merged across soon :)

tyronedougherty avatar Apr 26 '16 07:04 tyronedougherty

Fixed in #93, merged

tyronedougherty avatar Apr 27 '16 01:04 tyronedougherty

close ticket?

odilitime avatar Feb 19 '17 04:02 odilitime