xgboostExtension icon indicating copy to clipboard operation
xgboostExtension copied to clipboard

forward compatibility with xgboost 0.90

Open luoshao23 opened this issue 5 years ago • 3 comments

change positional arguments to keyword arguments for the forward compatibility with xgboost 0.90

luoshao23 avatar Nov 06 '19 06:11 luoshao23

When I used the xgboostExtension on xgboost 0.90, I found the XgbRanker class was not properly initialized with correct value in each argument. So I updated the arguments to keyword style for better compatibility.

luoshao23 avatar Nov 06 '19 06:11 luoshao23

When using XGBoost 0.90 or up I would propose using the XGBRanker object that has been made available as part of the scikit-learn api there instead of relying on this module. So maybe it would be better to make users aware that this is not meant to be used with that version?

FlorisHoogenboom avatar Nov 08 '19 13:11 FlorisHoogenboom

@FlorisHoogenboom I'm going to have a try and make the decision.

bigdong89 avatar Nov 15 '19 07:11 bigdong89