EduKTM icon indicating copy to clipboard operation
EduKTM copied to clipboard

Increase GKT's test coverage to 100%

Open fannazya opened this issue 2 years ago • 2 comments

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

Description

Increase GKT's test coverage to 100%

What does this implement/fix? Explain your changes.

Increase GKT's test coverage to 100%

Pull request type

  • [ ] [DATASET] Add a new dataset
  • [x] [BUGFIX] Bugfix
  • [ ] [FEATURE] New feature (non-breaking change which adds functionality)
  • [ ] [BREAKING] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] [STYLE] Code style update (formatting, renaming)
  • [ ] [REFACTOR] Refactoring (no functional changes, no api changes)
  • [ ] [BUILD] Build related changes
  • [ ] [DOC] Documentation content changes
  • [ ] [Sync] Synchronization with a repository
  • [ ] [OTHER] Other (please describe):

Changes

rnn.py and GKTNet.py

Does this close any currently open issues?

no

Any relevant logs, error output, etc?

no

Checklist

Before you submit a pull request, please make sure you have to following:

Essentials

  • [x] PR's title starts with a category (e.g. [BUGFIX], [FEATURE], [BREAKING], [DOC], etc)
  • [x] Changes are complete (i.e. I finished coding on this PR)
  • [x] All changes have test coverage and al tests passing
  • [x] Code is well-documented (extended the README / documentation, if necessary)
  • [x] If this PR is your first one, add your name and github account to AUTHORS.md

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

fannazya avatar May 29 '22 08:05 fannazya

Codecov Report

Merging #28 (1ff0b32) into main (2d4d545) will increase coverage by 0.85%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main       #28      +/-   ##
===========================================
+ Coverage   99.14%   100.00%   +0.85%     
===========================================
  Files          30        30              
  Lines        1517      1495      -22     
===========================================
- Hits         1504      1495       -9     
+ Misses         13         0      -13     
Impacted Files Coverage Δ
EduKTM/GKT/GKTNet.py 100.00% <100.00%> (+8.40%) :arrow_up:
EduKTM/utils/torch/rnn.py 100.00% <100.00%> (+3.94%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2d4d545...1ff0b32. Read the comment docs.

codecov-commenter avatar May 29 '22 08:05 codecov-commenter

If you use deletion to meet the requirement of coverage, you might meet problem when developing SKT.

tswsxk avatar May 30 '22 00:05 tswsxk