EduCDM icon indicating copy to clipboard operation
EduCDM copied to clipboard

Add ICD model in branch 2.0

Open ViviHong200709 opened this issue 1 year ago • 1 comments

Thanks for sending a pull request! Please make sure you click the link above to view the contribution guidelines, then fill out the blanks below.

Description

Add ICD. Incremental Cognitive Diagnosis, a framework that tailor cognitive diagnosis into the online scenario of intelligent education. In this repository we provide the several implementations for most of CDMs.

What does this implement/fix? Explain your changes.

...

Pull request type

  • [ ] [DATASET] Add a new dataset
  • [ ] [BUGFIX] Bugfix
  • [x] [FEATURE] New feature (non-breaking change which adds functionality)
  • [ ] [BREAKING] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] [STYLE] Code style update (formatting, renaming)
  • [ ] [REFACTOR] Refactoring (no functional changes, no api changes)
  • [ ] [BUILD] Build related changes
  • [ ] [DOC] Documentation content changes
  • [ ] [Sync] Synchronization with a repository
  • [ ] [OTHER] Other (please describe):

Changes

Add ICD

Does this close any currently open issues?

no

Any relevant logs, error output, etc?

no

Checklist

Before you submit a pull request, please make sure you have to following:

Essentials

  • [x] PR's title starts with a category (e.g. [BUGFIX], [FEATURE], [BREAKING], [DOC], etc)
  • [x] Changes are complete (i.e. I finished coding on this PR)
  • [x] All changes have test coverage and al tests passing
  • [x] Code is well-documented (extended the README / documentation, if necessary)
  • [x] If this PR is your first one, add your name and github account to AUTHORS.md

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

ViviHong200709 avatar Feb 08 '24 09:02 ViviHong200709

Codecov Report

Attention: 183 lines in your changes are missing coverage. Please review.

Comparison is base (49c686f) 88.72% compared to head (610afb6) 80.49%.

Files Patch % Lines
EduCDM/ICD/sym/fit_eval.py 29.77% 92 Missing :warning:
EduCDM/ICD/sym/net/net.py 61.01% 46 Missing :warning:
EduCDM/ICD/metrics/metrics.py 78.82% 18 Missing :warning:
EduCDM/ICD/etl/utils.py 33.33% 10 Missing :warning:
EduCDM/ICD/etl/etl.py 94.26% 7 Missing :warning:
EduCDM/ICD/sym/net/ncd.py 75.00% 7 Missing :warning:
EduCDM/ICD/sym/pos_linear.py 71.42% 2 Missing :warning:
EduCDM/ICD/ICD.py 98.80% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.0      #52      +/-   ##
==========================================
- Coverage   88.72%   80.49%   -8.23%     
==========================================
  Files          13       27      +14     
  Lines         745     1369     +624     
==========================================
+ Hits          661     1102     +441     
- Misses         84      267     +183     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 08 '24 09:02 codecov-commenter