stencil-cli icon indicating copy to clipboard operation
stencil-cli copied to clipboard

dart-sass as a primary SCSS compiler

Open andreyvolokitin opened this issue 2 years ago • 2 comments

Is there a reason node-sass is used? 4.1.0 release makes it a default, despite that 3.6.0 release relied on dart-sass. But node-sass is buggy and stale (critical regression active since 2019: https://github.com/sass/node-sass/issues/2330). Can dart-sass be used instead?

andreyvolokitin avatar Oct 03 '22 22:10 andreyvolokitin

@andreyvolokitin We had to revert dart sass compilation due to performance implications, so currently it is not being supported.

jairo-bc avatar Oct 04 '22 10:10 jairo-bc

Currently, both latest node-sass and a fork have bugs (see https://github.com/bigcommerce/stencil-cli/issues/600#issuecomment-1265819379). I was able to mitigate this using a fork on both CLI (using old version) and server-side (fork is used there). But I believe using dart-sass is the most stable and safe option from the actual code output standpoint

andreyvolokitin avatar Oct 04 '22 11:10 andreyvolokitin