stencil-cli icon indicating copy to clipboard operation
stencil-cli copied to clipboard

Published 20 hours ago • verified publisher icon bigcommerce

Cycles JS throws invalid circular dependency error

Open mattcoy-arcticleaf opened this issue 1 year ago • 0 comments

Expected behavior

Because you can include a component inside itself, and Cornerstone does this in a number of places, you should also be able to have circular component dependencies. https://github.com/bigcommerce/stencil-cli/blob/master/lib/Cycles.js#L41

See usage in Cornerstone:

  • https://github.com/bigcommerce/cornerstone/blob/master/templates/components/common/navigation-dropdown.html
  • https://github.com/bigcommerce/cornerstone/blob/master/templates/components/faceted-search/facets/hierarchy-children.html

Actual behavior

If you include a component inside another component, and that component includes the first component, Cycles JS throws an error saying Error: Circular dependency in template detected.

Steps to reproduce behavior

Include component X inside component Y, then include component Y inside component X.

Environment

Stencil-cli version stencil --version: 7.0.1

Node version node -v: v18.15.0

NPM version npm -v: 9.6.4

OS: Mac 13.4.1

mattcoy-arcticleaf avatar Sep 11 '23 17:09 mattcoy-arcticleaf