stencil-cli icon indicating copy to clipboard operation
stencil-cli copied to clipboard

`stencil bundle` silently fails when slash in theme name

Open Christopher-Hayes opened this issue 2 years ago • 1 comments

Expected behavior

stencil bundle should fail with a message that it doesn't support forward slashes in the theme name.

Actual behavior

stencil bundle doesn't throw any errors. The last log to console is:

ok -- Manifest Generation Finished

before the command appears to complete successfully.

However, no zip file appears in the repository.

By comparison, when stencil bundle actually completes successfully, the last output is:

ok -- Manifest Generation Finished
ok -- Zipping Files Finished
Bundled saved to: <zip path here>.zip

Steps to reproduce behavior

  1. In the config.json, update the theme name to have a forward slash, ie: "name": "test/test",
  2. Run stencil bundle
  3. The CLI command will complete without error; however, no .zip file appears.

Environment

Stencil-cli version stencil --version: 5.1.0

Node version node -v: v14.19.3

NPM version npm -v: 6.14.17

OS: macOS v12.6 (Monterey)

Christopher-Hayes avatar Nov 14 '22 18:11 Christopher-Hayes

I second this, this got me. Thank you for reporting it! I love silent fails.

focusede avatar Jul 28 '23 18:07 focusede