bigcommerce
Fix clear_active_connections! with no argument deprecation warning
We're using gruf v2.20.1, and still experience the deprecation warning for clear_active_connections!.
DEPRECATION WARNING: `clear_active_connections!` currently only applies to connection pools in the current role (`reading`).
In Rails 7.2, this method will apply to all known pools, regardless of role. To affect only those connections belonging to a specific role, pass the role name as an argument.
To switch to the new behavior, pass `:all` as the role name. (called from block in call at gruf/lib/gruf/interceptors/active_record/connection_reset.rb:32)>
This is caused by rails/rails#45924.
~~If you're still supporting Rails < 7.1, then we should change this to use ActiveRecord::Base.current_role, but I thought your goal was to clear any and all active connections -- please correct me if I'm wrong.~~
EDIT: I think supporting Rails 7.0 is a good idea, but I think you lose the ability to clear those connections in the other pools.
Due to Gruf::Controllers::Base rewriting the error message, actually the backtrace location was confusing.
Maybe fail! could be fixed to include it in the message, but that is beyond the scope of this PR.
Similar to #208 but for a separate deprecation warning when using multiple roles.
Sorry I just saw #211 but I think this PR is better because specs are passing and doesn't break backwards compatibility.
@splittingred Sorry for the ping, would you mind taking a look at this when you have time?
The linter was failing so I just rebased and fixed that a few days ago. Thanks! :pray: