gruf icon indicating copy to clipboard operation
gruf copied to clipboard

Fix integration with Rails when controllers_path is modified

Open salmanasiddiqui opened this issue 1 year ago • 2 comments

What? Why?

Fixes #215

The steps to reproduce are described in the above linked issue.

I was thinking that to fix this issue I will have to check config.eager_load but after_initialize works fine in both cases.

How was it tested?

Created a new rails app locally, followed the steps in the linked issue to reproduce error. Then updated the gem with the change in this PR. That fixed the issue.

I am thinking on how to write a test for this, any help or suggestion would be greatly appreciated. As this depends on how rails app is initialized its kinda hard to test this in isolation. It might be good to have a build step where gruf-demo is checked out and we test this in that?

salmanasiddiqui avatar Nov 09 '24 14:11 salmanasiddiqui

@splittingred 👋🏽 can you give this small fix a look?

salmanasiddiqui avatar Nov 09 '24 20:11 salmanasiddiqui

We are working to make a Rails 6.1 app Zeitwerk compatible, and we're running into the same issue as #215 with controllers_path being configured, and then encountering the Zeitwerk conflict. This patch does fix it for us as well.

Is there any chance this PR can get some movement again?

phoffer avatar Jul 10 '25 15:07 phoffer